Remove allow_time_extrapolation attribute on Field#1999
Merged
fluidnumericsJoe merged 10 commits intov4-devfrom May 13, 2025
Merged
Remove allow_time_extrapolation attribute on Field#1999fluidnumericsJoe merged 10 commits intov4-devfrom
fluidnumericsJoe merged 10 commits intov4-devfrom
Conversation
When a xarray or uxarray dataarray does not have a time dimension, one is added to the Field.data dataarray. When a field.data datarray has a time dimension that is length 1, we assume that extrapolation is allowed meaning that we just keep using the same single time-slice for that field.
VeckoTheGecko
requested changes
May 6, 2025
Contributor
|
I think it would be easier to rely on the |
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
3 tasks
The beginning of time when not provided is the date of the first parcels commit
VeckoTheGecko
approved these changes
May 7, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good! Minor feedback
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a xarray or uxarray dataarray does not have a time dimension, one is added to the Field.data dataarray. When a field.data datarray has a time dimension that is length 1, we assume that extrapolation is allowed meaning that we just keep using the same single time-slice for that field.
mainfor v3 changes,v4-devfor v4 changes)